Allow the use of the right keys for one-click #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a quick read of the code, I think this is a good solution - I'm having to assume some stuff so I'll have to test myself later (I'm busy this afternoon) or I'll quiz you in place of that! Edit:
Bug in the PR:
There might be some other oversights too. Catch you later. |
Nice catch, will look into fixing this -> Should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the define keys menu, the user would press right shift/ctrl/alt to use on the one-click room commands and it would accept it as the general 'shift/control/alt', but then ingame would only accept pressing the left key. Now it accepts either.
Fixes #3415